Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWN-8905 - UiKit. Informer view #1874

Merged
merged 5 commits into from
Jun 26, 2023
Merged

PWN-8905 - UiKit. Informer view #1874

merged 5 commits into from
Jun 26, 2023

Conversation

gslevinkov
Copy link
Contributor

Jira Ticket

https://p2pvalidator.atlassian.net/browse/PWN-8905

Screenshots (Optional)

In app example #1 Figma #2
Screenshot 2023-06-26 at 01 33 16 Screenshot 2023-06-26 at 01 32 57

@gslevinkov gslevinkov added the WIP Work in progress label Jun 25, 2023
@gslevinkov gslevinkov requested a review from 1sakov as a code owner June 25, 2023 17:34
@gslevinkov gslevinkov self-assigned this Jun 25, 2023
@gslevinkov gslevinkov requested a review from a user June 25, 2023 17:34
gslevinkov
gslevinkov commented Jun 25, 2023
View reviewed changes
ui-kit/src/main/res/layout/fragment_striga_iban_account.xml Outdated
@@ -0,0 +1,154 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@gslevinkov gslevinkov changed the title WIP: PWN-8905 - UiKit. Informer view PWN-8905 - UiKit. Informer view Jun 26, 2023
@gslevinkov gslevinkov removed the WIP Work in progress label Jun 26, 2023
@github-actions
Copy link

Code coverage report

File Coverage [0.00%]
app/src/main/java/org/p2p/wallet/debug/settings/DebugSettingsMapper.kt 0.00%
app/src/main/java/org/p2p/wallet/debug/uikit/DebugInformerViewBuilder.kt 0.00%
app/src/main/java/org/p2p/wallet/debug/uikit/DebugUiKitFragmentPresenter.kt 0.00%
Total Project Coverage 7.21%

@gslevinkov gslevinkov merged commit 5bc570c into develop Jun 26, 2023
2 of 3 checks passed
@gslevinkov gslevinkov deleted the feature/PWN-8905-informer-view branch June 26, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardmaximovich eduardmaximovich eduardmaximovich approved these changes

@1sakov 1sakov 1sakov approved these changes

@Davran331122 Davran331122 Awaiting requested review from Davran331122

Assignees

@gslevinkov gslevinkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gslevinkov @1sakov @eduardmaximovich